refactor(Rows): switch front-end to use Row OCS API #1351

blizzz · 2024-09-12T13:25:54Z

includes

a fix of the RowDataInput – has to be iterable, otherwise values were stored empty 🙈
and a fix to accept selection-type values with the rows ocs endpoint
and extended tests

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz added 9 commits September 12, 2024 14:55

test(behat): add tests on adding columns to views

3eeb110

Signed-off-by: Arthur Schiwon <[email protected]>

fix(Controller): respond with 400 on InvalidArgumentExceptions

94da27a

Signed-off-by: Arthur Schiwon <[email protected]>

fix(Model): RowDataInput must be iterable

a83dbcd

Signed-off-by: Arthur Schiwon <[email protected]>

test(behat): fix view had no columns assigned

011d3c4

Signed-off-by: Arthur Schiwon <[email protected]>

test(behat): check that returned created row matches input values

0844c6e

Signed-off-by: Arthur Schiwon <[email protected]>

refactor(Rows): switch front-end to use Row OCS API

fcbba69

Signed-off-by: Arthur Schiwon <[email protected]>

refactor(Controller): increase use of Permission middleware

483aace

Signed-off-by: Arthur Schiwon <[email protected]>

fix: create rows with selection cols via RowOCSController

20d3124

Signed-off-by: Arthur Schiwon <[email protected]>

build(openapi): ts types

d3436e8

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews labels Sep 12, 2024

blizzz added this to the v0.8.0 milestone Sep 12, 2024

blizzz requested review from juliushaertl and enjeck September 12, 2024 13:25

style(js): satisfy stylelint

b94be07

Signed-off-by: Arthur Schiwon <[email protected]>

juliushaertl approved these changes Sep 12, 2024

View reviewed changes

blizzz merged commit 52846ad into main Sep 12, 2024
61 checks passed

blizzz deleted the fix/use-ocs-row-create branch September 12, 2024 15:47

Provide feedback